Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the client, API improvements #9

Merged
merged 31 commits into from
Oct 8, 2017
Merged

Test the client, API improvements #9

merged 31 commits into from
Oct 8, 2017

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Oct 4, 2017

Pull Request for Issue #6

Summary of Changes

  • Adds a functional test class covering the LdapClient
  • Adds tracking state to make sure the connection is bound
  • Adds a destructor to make sure the connection is closed when the object destroyed
  • Adds checks to make sure the connection is established and bound when needed since we cannot lazy bind

Testing Instructions

Either put some trust in a green CI build or try to set up a LDAP server and use the client

@mbabker
Load data into LDAP server
089a945
@mbabker
Adjust
6b21117
@mbabker
Sleep
6fa693a
@mbabker
Right password
d0293d7
@mbabker
Constructor internally dependent on Registry, implement test env setu…
43cd3d0 
…p and a test for the connect method
@mbabker
Add destructor to client, expand close method a bit, tests for DN met…
b433907 
…hods, dump anon bind
@mbabker
Test tweaks, expand test coverage
02f4920
@mbabker
Implement tests, dump error message
c36c5c4
@mbabker
Set v3 flag
9558412
@mbabker
Explicitly check for boolean false otherwise the env var is set and s…
69bbc8a 
…hould be used
@mbabker
Expose ldap_unbind(), dump DN at bind to make sure things are right
326b827
@mbabker
Pass DN through bind so it isn't wiped out
2f4e2a4
@mbabker
Tweak DN setting in test, track bound state from bind method
a24dc81
@mbabker
Shortcut check for connection, don't try to search if not bound/conne…
dcb3152 
…cted, start search test
@mbabker
Have to set base DN
f4900c1
@mbabker
More search tests
eef0757
@mbabker
Merge branch 'master' of github.com:joomla-framework/ldap into tests
b64b305
@mbabker
Replace
f5843ed
@mbabker
Check for connection, tests
0e93c42
@mbabker
Test tweaks
52402fc
@mbabker
One more test tweak
97af3f3
@mbabker
Test read
feb32be
@mbabker
Tweak dump spot
74f7e59
@mbabker
Next try
7fd4550
@mbabker
Should finish test up
a0bac49
@mbabker
Test delete
fe968c4
@mbabker
Create test
93424ce
@mbabker
Add/Rename tests
298577c
@mbabker
Check for connection on get error, codestyle
f9de807
@mbabker
A round of doc block cleanup
72f1543
@wilsonge wilsonge merged commit e0c19e6 into master Oct 8, 2017
@mbabker mbabker deleted the tests branch October 8, 2017 14:39
@mbabker mbabker mentioned this pull request Oct 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbabker @wilsonge